Cleaning up #403
Merged
Cleaning up #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs locally when trying to retrieve some JSON from the response, which fails since we can't retrieve the version.json file. However, we don't care when this happens since it only happens when testing things locally.
There was a problem hiding this comment.
Pull request overview
This PR performs small cleanup changes in the renderer update-checking logic and bumps the project version.
Changes:
- Remove error logging from the web update-checking
catchpath. - Bump version from
0.20260209.0to0.20260209.1in both root and rendererpackage.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer/src/common/version.ts | Adjusts error handling behavior when the web app checks for updates. |
| src/renderer/package.json | Increments renderer package version. |
| package.json | Increments root package version. |
Comments suppressed due to low confidence (1)
src/renderer/src/common/version.ts:60
- The catch block now swallows all fetch/JSON/network errors without any logging. That makes update-check failures silent and harder to diagnose in production (e.g., CORS issues, malformed version.json). Consider keeping a minimal warning (optionally gated to dev) and/or formatting the caught error before resetting state.
} catch (_error: unknown) {
updateAvailable.value = false;
latestVersion.value = '';
return false;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.